Repository navigation
fix: address the review follow-ups on the manifest scripts - #96
Merged
Merged
Conversation
- build-codex-zip.mts: the SystemRoot fallback was 'C:\Windows', which a single backslash turned into C:Windows. Escape it. - sync-manifests.mts: only rewrite the version in the two sample output lines of .github/README.md, so other version numbers there (such as a Codex CLI version) are left alone. The script fails if a sample line goes missing. Co-Authored-By: Claude Opus 5.5 <[email protected]>
ziyiunity
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run-NaN:
Fixes the two issues raised in the review on #93, which merged before they were addressed.
build-codex-zip.mts: the Windows fallback path was written'C:\Windows'.\Wisn't a JS escape, so it ran asC:Windows. It's now'C:\Windows'. It only applied whenSystemRootis unset.sync-manifests.mts: the README update used to rewrite any0.x.yin.github/README.md, so a mention of another tool's version (the Codex CLI is 0.x) would have been overwritten. It now changes only the two sample output lines (codex plugin listandagy plugin list). If either line goes missing, the script fails instead of silently skipping it.tsc -p scripts/tsconfig.jsonsync-manifests.mts --checkon this branchCodex CLI 0.163.0line added to the README--checkpassesbuild-codex-zip.mts🤖 Generated with Claude Code