Repository navigation
Conversation
Default-initialize PrincipalType::unreachable so the Signature constructor does not leave it uninitialized, and grow AssignmentClasses sets up to max(i, *other) before looking up classes.getRoot(*other). Implement the remaining join cases for VarNullability, VarExactness, VarSharedness, VarHeapType (including mixed abstract/defined heap types and defined heap types with basic LUBs), and VarRef/Type, as well as erasing leading unreachable elements at the bottom of results in PrincipalType::compose.
tlively
requested review from
aheejin and
kripken
and removed request for
a team
October 23, 2026 21:31
There was a problem hiding this comment.
Code Review
This pull request implements support for joining abstract and defined heap types, refactors nullability, exactness, and sharedness join operations, and improves the handling of unreachable types during principal type composition. It also adds comprehensive unit tests to verify these changes. As there are no review comments, I have no feedback to provide.
Member
Author
|
Here is the plan:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default-initialize PrincipalType::unreachable so the Signature constructor does not leave it uninitialized, and grow AssignmentClasses sets up to max(i, *other) before looking up classes.getRoot(*other).
Implement the remaining join cases for VarNullability, VarExactness, VarSharedness, VarHeapType (including mixed abstract/defined heap types and defined heap types with basic LUBs), and VarRef/Type, as well as erasing leading unreachable elements at the bottom of results in PrincipalType::compose.