Repository navigation
REST API: Sanitize comment statuses in a single pass. - #14752
adamsilverstein wants to merge 1 commit into
Conversation
Replace the chained array_map/array_unique/array_filter/array_values calls in sanitize_comment_statuses() with one loop, avoiding the intermediate arrays. Behavior is unchanged; add test cases covering duplicates that only collide after sanitizing, empty values inside an array, and non-scalar values. Follow-up to a review suggestion on WordPress#9870. See #63982. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_015KyhSZWbcaixA5gHomFjXT
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
Code-wise this looks good to me. |
not that I really care, but it appears that Claude copied my code verbatim, which is more like “Claude Code copy/pasted the code” 🤷♂️ |
Description updated. |
Follow up to #9870 (comment) - thanks @dmsnell for the suggestion.
Claude made the change @dmsnell sketched out, summary below:
Testing
npm run test:php -- --filter test_sanitize_comment_statuses(not run locally yet, leaning on CI for the PHPUnit run).Trac ticket: https://core.trac.wordpress.org/ticket/63982
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Claude Code
wrotecopied the code, wrote tests and this description, starting from the reviewer's snippet. I reviewed.This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.
🤖 Generated with Claude Code
https://claude.ai/code/session_015KyhSZWbcaixA5gHomFjXT
Commit message