Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Model finalizers can run after Python clears module globals, causing the cleanup callbacks to raise
TypeError: 'NoneType' object is not callableorAttributeErrorwhile releasing native resources.Capture the native release functions when registering the ExitStack callbacks for models, contexts, batches, samplers (including clones/custom samplers), and LoRA adapters. The callbacks retain their existing release order and idempotent close behavior through module teardown.
Fixes #1998.
Fixes #2002.
Validation on Windows CPU, Python 3.12.13, with the native library built from the pinned llama.cpp revision
0c1e57098using LLVM-MinGW/Ninja (GGML_NATIVE=OFF,GGML_OPENMP=OFF,_WIN32_WINNT=0x0A00):python -m pytest tests -q: 32 passed, including the Qwen3.5, Mamba, Falcon-H1, tiny Llama, and embedding-model tests.stories260K.ggufinference generated eight tokens before explicit close and garbage collection with the bindings module reference cleared; both completed without unraisable exceptions.