Repository navigation
Map the OSV crates.io ecosystem to cargo - #2486
Open
Ashutosh-Panda2004 wants to merge 1 commit into
Open
Ashutosh-Panda2004 wants to merge 1 commit into
Ashutosh-Panda2004 wants to merge 1 commit into
Conversation
OSV calls the Rust ecosystem crates.io, but the ecosystem mapping only had a cargo key, so every crates.io affected entry was skipped. Signed-off-by: Ashutosh Panda <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2485
OSV calls the Rust ecosystem crates.io, but PURL_TYPE_BY_OSV_ECOSYSTEM in vulnerabilities/importers/osv.py only had a cargo key, so the lookup failed for every real crates.io advisory and the affected entry was skipped.
I added a "crates.io": "cargo" entry to the mapping, keeping the existing cargo key, and added a regression test where a crates.io advisory for serde produces pkg:cargo/serde with its fixed version.
Signed-off-by: Ashutosh Panda [email protected]