Repository navigation
fix power-on processing when running on batteries - #11693
Merged
Merged
Conversation
dhalbert
approved these changes
Oct 30, 2026
dhalbert
left a comment
dhalbert
left a comment
Collaborator
There was a problem hiding this comment.
Thanks!
@Gadgetoid Is this relevant for you for MicroPython, etc.? Do you already know about this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes power-on behavior when running on batteries and makes the initial button state available.
Currently, power is latched in
board_init(), which can take 3-10s until it runs (depending e.g. on web-workflow). The user has to press the button this long to keep the system running. This PR latches power early, and also saves the state of the shift-register so the user can later query which button was used to turn the system on.For the Inky-Frame 7.3 there is some additional code-cleanup:
board_init()it created three DigitalInOuts locally, but they were never exposed so the pins were not available anymore.