Repository navigation
Fix draw_polygon and draw_circle leaving pixels off the screen - #11701
Open
mikeysklar wants to merge 2 commits into
Open
mikeysklar wants to merge 2 commits into
mikeysklar wants to merge 2 commits into
Conversation
…area The dirty area's x2 and y2 are exclusive, but draw_polygon passed the largest x and y it drew. Pixels on the right and bottom edges stayed off the display, and purely horizontal or vertical lines did not appear. Fixes adafruit#9239. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Collaborator
Author
|
@lynt-smitka your cp-desktop-lab reproduced this before I tried it on a CLUE. Comparing its screenshots with the bitmap showed exactly which pixels were missing, which pointed to the cause. Thanks, it was really helpful! |
The same exclusive-limit mistake as draw_polygon: pixels on the right and bottom edges stayed off the display, and a circle of radius 0 did not appear. Co-Authored-By: Claude Opus 5.5 <[email protected]>
mikeysklar
changed the title
draw_polygon leaving pixels off the screendraw_polygon and draw_circle leaving pixels off the screen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Polygons and circles drawn with
bitmaptoolsnow fully appear on the display.Why
The right and bottom edges were left out of the screen update.
Fixes #9239.
Testing
mainmainThe CLUE tested each fix on its own. The lab also tested both together. CLUE builds had
hashlibturned off. Desktop lab is cp-desktop-lab. Other boards not tested.draw_polygonon a CLUE, stock on the left, fixed on the right:draw_circleon a CLUE, stock on the left, fixed on the right:AI assistance
Claude helped find and test this. I checked the CLUE results.
🤖 Generated with Claude Code