Repository navigation
Release extra displays when code finishes - #11702
Merged
Merged
Conversation
Uncomment the release in reset_displays(). The bus loop compared bus slots with the primary's display slot, but the two are allocated separately, so it could release the primary's bus and keep a spare. Skip the bus the primary actually uses instead. With no primary left, stop the terminal so a later display doesn't get one sized for the old display. Update the docs that said displays stay active until release_displays(). Fixes adafruit#10063. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Collaborator
Author
|
@lynt-smitka your cp-desktop-lab worked on this before any hardware verification. It reproduced the problem and showed that the suggested one-line fix released the wrong bus. A CLUE and a Metro RP2040 then confirmed the result. Thanks again! |
dhalbert
requested changes
Nov 1, 2026
dhalbert
left a comment
dhalbert
left a comment
Collaborator
There was a problem hiding this comment.
Reference problem in new doc:
/home/runner/work/circuitpython/circuitpython/shared-bindings/busdisplay/index.rst:639:'any' reference target not found: supervisor.runtime.display [ref.any]
supervisor.runtime is an instance, so the doc reference doesn't resolve. Keep the text users type and link it to supervisor.Runtime.display. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Collaborator
Author
|
Thanks. Fixed the doc reference. It was in several display modules, so I corrected all of them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Displays not set as
supervisor.runtime.displayare now released when your code finishes.Why
Their pins stayed busy, so the same code failed on its next run.
Fixes #10063.
Behaviour change
supervisor.runtime.display = dDisplays released this way should no longer show the REPL after your code exits.
Testing
Too many display bussesfrom run 2Too many display bussesD9 in useBuilt-in CLUE display still shows the console and paints. No real second panel, backlight or e-paper tested. CLUE builds had
hashlibturned off. Desktop lab is cp-desktop-lab.CLUE, stock on the left, fixed on the right:
Desktop lab, before on the left, after on the right:
AI assistance
Claude helped find and test this. I checked the results.
🤖 Generated with Claude Code