Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an embedding request raises,
get_embedding()returns a(vector, cost)tuple even though its callers expect a vector. Two such failures can therefore reach NumPy as ragged two-element sequences and crash database novelty checks instead of following the existing empty-vector fallback.I return
[]for a failed string input and one empty vector per failed batch input. Successful responses, provider requests, and error logging are unchanged. This also keeps batch result cardinality aligned with the input and corrects the return-value docstring.Validation:
ProgramDatabase.add()admission through single and consecutive outages (2D and 3D vectors).git diff --checkpassed.I directed this focused contribution and used OpenAI Codex assistance for reproduction, implementation, tests, and diff review. SDK responses and errors are local fixtures; no live provider calls were made. Existing malformed embeddings in old checkpoints are not migrated.