[aecsar]

Building with zig 0.17.0 on macOS fails at link time:

error: duplicate symbol definition: _ntlm_md4_digest
note: defined by .../libntlmclient.a(crypt_builtin_md4.o)
note: defined by .../libntlmclient.a(crypt_commoncrypto.o)

build.zig compiles the ntlmclient static library from two lists:

• tls-backend specific file (crypt_openssl.c, crypt_mbedtls.c, or crypt_commoncrypto.c).
• ntlm_sources, which unconditionally contained crypt_builtin_md4.c.

crypt_commoncrypto.c already defines ntlm_md4_digest
(https://github.com/libgit2/libgit2/blob/42a89d7cc9374a19e72fa57011e5fe3a99c7b3bf/deps/ntlmclient/crypt_commoncrypto.c#L76),
and crypt_builtin_md4.c defines the same function (https://github.com/libgit2/libgit2/blob/42a89d7cc9374a19e72fa57011e5fe3a99c7b3bf/deps/ntlmclient/crypt_builtin_md4.c#L293).

On the securetransport backend
both objects end up in libntlmclient.a, so the symbol is defined twice.

Upstream libgit2's CMake only adds crypt_builtin_md4.c to the mbedtsl backend https://github.com/libgit2/libgit2/blob/42a89d7cc9374a19e72fa57011e5fe3a99c7b3bf/deps/ntlmclient/CMakeLists.txt#L34

I guess older zig version tolerated the duplicate.

[Parzival-3141]

CI failures seem to be unrelated. I'll test again after updating the repo and CI to 0.17.0.

[Parzival-3141]

The patch passes CI for 0.17.0 (the windows failure seems unrelated). Since this patch is technically version agnostic I'll merge it now before updating to 0.17.0.