Repository navigation
fix: honor configured lexer rules for delimited tokens - #943
Open
Sarbajit-Sengupta wants to merge 1 commit into
Open
Sarbajit-Sengupta wants to merge 1 commit into
Sarbajit-Sengupta wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lexer.clear()andset_SQL_REGEX()no longer control block comments and dollar-quoted literals because delimiter handling runs before the configured rules. A lexer configured with only(r".+", tokens.Name)still returnsComment.Multilinefor/* comment */andLiteralfor$$body$$.Move delimiter resolution into a marker rule in the default
SQL_REGEXsequence. Custom rules can then override or omit it, while default lexing keeps the indexed delimiter scanner. Add six regression cases and document the rule's behavior.Validation: 512 passed, 2 xfailed, 1 xpassed; Ruff and
git diff --checkpassed. Both delimiter benchmark vectors remained linear at sizes 1,000/2,000/4,000 (exponents 1.02 and 1.16).pytest)ruff)