[armando-navarro]

Checklist

• Issue number for this PR: Make firebase a peer dependency of @angular/fire #3804
• Docs included?: yes. docs/version-22-upgrade.md is new, with its README link. The README and quickstart install commands follow in their own pull request, held until 22.0.0 is published.
• Test units included?: yes. src/schematics/update/v22/index.jasmine.ts, and the firebaseVersionRange spec now reads the peer entry.
• Breaking change?: yes. BREAKING CHANGE: footer in the commit, ! in the subject.
• In a clean directory, yarn install, yarn test run successfully? yes, with npm: npm ci, npm run build, npm run lint, npm run test:node (389 specs) and npm run test:chrome-headless (112 specs) pass.

Description

Through v21, @angular/fire listed firebase under dependencies, so an app that asked for a different version got a second copy of the SDK nested under @angular/fire, and the two copies rejected each other's objects at runtime. With firebase as a peer dependency there is exactly one copy, and an incompatible version is refused at install time on npm. The reasoning and the alternatives are in #3804.

Changes

• src/package.json: firebase ^12.18.0 moves from dependencies to peerDependencies. src/ng-package.json drops it from allowedNonPeerDependencies.
• migration-v22 (src/schematics/update/v22/index.ts, registered in migration.json at 22.0.0, tools/build.ts and the schematics tsconfig.json): calls alignFirebaseVersion and schedules an install only when it changed something.
  • ng update rewrites a firebase entry the app already declares before any migration runs, but writes nothing for an app with no entry, so the migration exists for that case.
  • A rerun changes nothing, which ng update relies on across prerelease steps.
• alignFirebaseVersion: the comment and its two log messages no longer say that @angular/fire bundles firebase, and they no longer describe one package manager's behavior. The firebaseVersionRange comment and spec tie the literal to peerDependencies.firebase.
• Both migration descriptions say "the range @angular/fire requires" with no version number, since both read the one firebaseVersionRange constant.
• docs/version-22-upgrade.md: the run-the-update command, what the migration does, and the "Your app now owns the Firebase SDK" section (npm, ERESOLVE, Yarn, pnpm). The commands say @angular/fire@canary, the only installable 22 build today, and move to @next and @22 as those tags exist.

Behavior to know

• npm 7 and later install the missing peer by themselves but write no firebase entry. ng update adds it. npm install @angular/fire@canary by hand leaves the app working with an undeclared dependency, which the guide tells the reader to declare.
• pnpm and Yarn install an out-of-range firebase as one copy with a warning, and legacy-peer-deps=true in an .npmrc makes npm do the same silently. The ng add and ng update alignment is what corrects those apps.
• The ng add warning for two installed firebase versions stays. Under a peer dependency, two copies appear only when another package bundles its own firebase.
• Not in this PR:
  • the README and quickstart install commands (own pull request, held until 22.0.0)
  • the firebase range itself (^12.18.0 today, ^12.19.0 is a separate decision)
  • @schematics/angular and @angular-devkit/schematics in dependencies (Move Schematic dependencies to peerDependencies or devDependencies #3694)

Verification

• Build, lint, test:node (389 specs, four of them the new migration's) and test:chrome-headless (112 specs) pass. The built package.json and the packed tarball list firebase ^12.18.0 as a peer and no firebase dependency.
• A fresh Angular 22.2 app with no firebase entry takes the packed tarball (npm 11 installs the peer, writes nothing), then ng update @angular/fire --migrate-only --from 21.0.0 --to 22.0.0 adds firebase ^12.18.0, reinstalls, and npm ls firebase shows one copy. The app builds with the Firestore providers wired in. A second run reports no changes.
• The same app requesting firebase ^11.0.0 fails npm install of the tarball with ERESOLVE, which reports peer firebase@"^12.18.0" from @angular/[email protected], nothing installed.
• The duplicate-firebase warning's acceptance list gained two projects installed from the 22 tarball: a plain install, where it stays silent, and one with a second package that bundles firebase 11, where it warns. All 18 rows pass.
• firebase 12.19.0, which the repo compiles against, adds no export over 12.18.0 in any of the 14 wrapped entry points, so the peer minimum is safe.

Fixes #3804
Refs #3684, #3681, #3682

[tyler-reitz]

Approving. Two small doc notes, neither blocking:

1. docs/version-22-upgrade.md says the migration updates an older firebase entry "to the current 12.x release". It writes ^12.18.0, and only when the existing entry falls outside that range, so "to ^12.18.0" would be exact.
2. The pnpm section says the unmet-peer warning prints "only once, when it first resolves the tree, never on a later install from the committed lockfile." Was that checked against pnpm? The verification section covers npm only, and readers will rely on that sentence.

Fine to land either as a follow-up.

[armando-navarro]

Thanks for the review, both notes were worth raising.

1. Fixed in 1038553. The sentence now says ^12.18.0, and that the entry is only rewritten when it falls outside that range, which is what the migration does.
2. It was checked on pnpm 9.15.4 while the change was being designed, and I reran it today against this PR's tarball on pnpm 9.15.4, 10.34.8, 11.28.8 and 12.15.0, with firebase 11.10.0 in the app.
   • On all four the warning prints on the first resolution and not on a second pnpm install, nor on pnpm install --frozen-lockfile from an empty node_modules.
   • What the rerun did turn up is that pnpm 11 changed the wording. pnpm 9 and 10 print unmet peer firebase@^12.18.0: found 11.10.0, pnpm 11 and 12 print Issues with peer dependencies found. Run "pnpm peers check" to list them. and that command names firebase. The same commit quotes both in the guide.