Repository navigation
fix(ng-dev): close linked issues when merging via autosquash into main - #4066
Merged
alan-agius4 merged 1 commit intoOct 26, 2026
Merged
Conversation
When a pull request is merged via the autosquash merge strategy, it is closed via a `PR Close #...` commit message rather than merged via the GitHub API. Consequently, GitHub does not automatically close linked issues even when targeting the main branch. This change ensures `closeLinkedIssues` is called for all autosquash merges regardless of target branch.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies the merge strategies to unconditionally close linked issues manually by moving the closeLinkedIssues call outside of a conditional block in AutosquashMergeStrategy and removing the main branch guard from the base MergeStrategy class. The review feedback points out that removing this guard globally may cause redundant API calls for other merge strategies. Instead, it is recommended to keep the main branch guard in the base class and introduce an optional force parameter to bypass it specifically for the autosquash merge strategy.
crisbeto
approved these changes
Oct 26, 2026
Contributor
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a pull request is merged via the autosquash merge strategy, it is closed via a
PR Close #...commit message rather than merged via the GitHub API. Consequently, GitHub does not automatically close linked issues even when targeting the main branch.This change moves
closeLinkedIssuesoutside thegithubTargetBranch !== this.git.mainBranchNameguard inAutosquashMergeStrategyand removes the redundant main branch check inMergeStrategy.closeLinkedIssues.