GH-55165: [C++] Force newer versions of Brotli by CurtHagenlocher · Pull Request #55167 · apache/arrow

CurtHagenlocher · 2026-10-23T23:40:49Z

Rationale for this change

It seemed like a good time for a change.

What changes are included in this PR?

Newer versions of the Brotli dependency are forced by the build.

Are these changes tested?

Presumably the relevant code paths already have tests.

Are there any user-facing changes?

No.

Was AI used for this PR?

PR code and description written by:

Human
AI

Reviewed before submission by:

Human
AI
Not reviewed

GitHub Issue: [C++] We should take a newer version of Brotli #55165

github-actions · 2026-10-23T23:41:58Z

⚠️ GitHub issue #55165 has been automatically assigned in GitHub to PR creator.

Copilot

🟡 Changes recommended

The Windows wheel image revision must also change to prevent cached images from bypassing the Brotli upgrade.

1 open issue

Bump Windows wheel image revision for Brotli update · New

What changed in this PR

This PR updates bundled Brotli versions across Arrow’s C++ build paths, addressing GH-55165.

Changes:

Updates the CMake dependency pin to Brotli 1.0.10 and its checksum.
Updates the Meson fallback to Brotli 1.1.1 with local build definitions and licensing.
Patches vcpkg to use Brotli 1.2.1 with an updated checksum.

File	Description
`cpp/thirdparty/versions.txt`	Updates the bundled Brotli version and checksum.
`cpp/subprojects/packagefiles/google-brotli/meson.build`	Adds local Meson build definitions for Brotli.
`cpp/subprojects/packagefiles/google-brotli/LICENSE.build`	Includes licensing for the Meson build definitions.
`cpp/subprojects/google-brotli.wrap`	Updates the source archive and selects the local build overlay.
`ci/vcpkg/ports.patch`	Updates the vcpkg Brotli version and checksum.

_{Review effort: Balanced}

Copilot

🔵 Needs a closer look

Compatibility of the new patch with the inaccessible pinned vcpkg port remains unverified and needs CI or human confirmation.

No open issues 🎉

1 resolved since last review

Bump Windows wheel image revision for Brotli update

_{Review effort: Balanced}

CurtHagenlocher · 2026-10-23T23:57:17Z

@github-actions crossbow submit wheel-windows-*

github-actions · 2026-10-23T23:59:35Z

Revision: 747092e

Submitted crossbow builds: ursacomputing/crossbow @ actions-41b08c9f7f

Task	Status
wheel-windows-cp311-cp311-amd64
wheel-windows-cp312-cp312-amd64
wheel-windows-cp313-cp313-amd64
wheel-windows-cp314-cp314-amd64
wheel-windows-cp314-cp314t-amd64
wheel-windows-cp315-cp315-amd64
wheel-windows-cp315-cp315t-amd64

CVE-2026-111497 (Brotli decoder out-of-bounds write) affects the Brotli 1.0.9 that Arrow 18 bundles. Apache Arrow ships fixes only in new major versions — the Brotli update (apache/arrow#55167, unmerged) targets main — so `pyarrow~=18.0` could never take it. pyarrow is now `>=18.0`; a rebuild installs 26.0.0 today (not fixed yet either) and the first fixed major on the rebuild after it ships. The manifest advertises the same constraint. The other packages keep `~=`: pandas 3, polars 2, DuckDB 2 and Pillow 13 change the API LLM-written code uses. With pyarrow 26.0.0, pandas 2.3.3, polars 1.44.2 and DuckDB 1.5.6, `pip check` is clean and parquet / DataFrame / DuckDB round-trips match pyarrow 18.1.0. ADR-0007 is amended and records what this release does not fix: DuckDB's vendored Brotli 1.1.0 (upstream fix unmerged) and Pillow's bundled libbrotlidec (WOFF2 only, not reached here). Co-Authored-By: Claude Opus 5.5 <[email protected]>

raulcd

Thanks for pushing this @CurtHagenlocher

raulcd · 2026-10-26T07:34:15Z

 ARROW_BOOST_BUILD_SHA256_CHECKSUM=f51707c27359a0df0cac1beada86de31bb5eed5e8285592dadec384df99c2984
-ARROW_BROTLI_BUILD_VERSION=v1.0.9
-ARROW_BROTLI_BUILD_SHA256_CHECKSUM=f9e8d81d0405ba66d181529af42a3354f838c939095ff99930da6aa9cdf6fe46
+ARROW_BROTLI_BUILD_VERSION=v1.0.10


Is there any reason we don't bump to something newer here? Given that we are bumping our bundle dependency we could try and bump to latest (1.2.1) unless other dependencies have other constraints.

A basic conservatism, I suppose. Given that 1.0, 1.1 and 1.2 were all patched, it seemed possible that there were some incompatibilities between them. We could try 1.2.1 and see if anything breaks.

Copilot

🔵 Needs a closer look

Compatibility of the broader vcpkg update with the remaining local port patches is unverified and needs human confirmation.

No open issues 🎉

_{Review effort: Balanced}

hiyasichuka · 2026-10-27T07:44:09Z

Could we rerun the Crossbow Windows wheel builds for the latest revision (8f4c06d)? The results linked above are for 747092e, before the vcpkg baseline update. It would be helpful to verify the latest wheel build and confirm that it includes Brotli 1.2.1.

…image - Apply meson-fmt to the vendored google-brotli meson.build (whitespace only). - Bump PYTHON_WHEEL_WINDOWS_IMAGE_REVISION so Windows wheel CI rebuilds its cached image with the patched vcpkg brotli 1.2.1 port instead of reusing the existing image built with 1.2.0. Co-Authored-By: Claude Opus 5.5 <[email protected]>

- Bump the vcpkg pin (.env, cpp/vcpkg.json, c_glib/vcpkg.json) to 61d7eaeb, the upstream commit that updates the brotli port to 1.2.1, and drop the brotli hunk from ci/vcpkg/ports.patch. - Drop the llvm hunk from ci/vcpkg/ports.patch: upstream restructured the port and the hunk no longer applies. - Revert the PYTHON_WHEEL_WINDOWS_IMAGE_REVISION bump; the image tag already changes with VCPKG. - Bump the bundled Brotli to v1.2.1. Brotli >= 1.1.0 names static libraries without the "-static" suffix and installs normally on Emscripten, so update build_brotli accordingly and stop building the CLI tool and tests. - Revert the Meson wrap changes; the C++ Meson build isn't used for any released artifact, so keep tracking WrapDB. Co-Authored-By: Claude Opus 5.5 <[email protected]>

Copilot

🔵 Needs a closer look

The broad vcpkg refresh and platform-specific build and linkage changes require cross-platform CI validation and human review.

No open issues 🎉

1 resolved since last review

Use configuration-aware archive path for Debug builds

_{Review effort: Balanced}

raulcd · 2026-10-27T16:54:27Z

@CurtHagenlocher let me know if I can follow this up. I have a local rebase with main fixing the conflict but I obviously don't want to force push on your branch without your explicit ok :) After the conflict is resolved I'd like to exercise the R binaries jobs.

CurtHagenlocher · 2026-10-27T17:17:10Z

@CurtHagenlocher let me know if I can follow this up. I have a local rebase with main fixing the conflict but I obviously don't want to force push on your branch without your explicit ok :) After the conflict is resolved I'd like to exercise the R binaries jobs.

Please do whatever is needed to deliver this fix!

raulcd · 2026-10-27T19:42:24Z

@github-actions crossbow submit -g r

github-actions · 2026-10-27T19:45:20Z

Revision: b93d56b

Submitted crossbow builds: ursacomputing/crossbow @ actions-d486ac7b81

Task	Status
r-binary-packages
r-recheck-most
test-r-alpine-linux-cran
test-r-arrow-backwards-compatibility
test-r-depsource-system
test-r-dev-duckdb
test-r-devdocs
test-r-extra-packages
test-r-fedora-clang
test-r-gcc-11
test-r-gcc-12
test-r-install-local
test-r-install-local-minsizerel
test-r-linux-as-cran
test-r-linux-rchk
test-r-linux-sanitizers
test-r-linux-valgrind
test-r-m1-san
test-r-macos-as-cran
test-r-offline-maximal
test-r-ubuntu-22.04
test-r-versions
test-r-wasm

Copilot

🔵 Needs a closer look

The broader vcpkg update and cross-platform linking changes need CI and human validation of compatibility with the pinned upstream ports.

No open issues 🎉

_{Review effort: Balanced}

raulcd · 2026-10-27T20:21:24Z

@github-actions crossbow submit wheel-cp313

Copilot

🔵 Needs a closer look

The broad vcpkg refresh and platform-specific dependency changes require cross-platform CI confirmation and human validation.

No open issues 🎉

_{Review effort: Balanced}

github-actions · 2026-10-27T20:24:34Z

Revision: 7ec72cf

Submitted crossbow builds: ursacomputing/crossbow @ actions-8c50bab9e5

Task	Status
wheel-macos-monterey-cp313-cp313-amd64
wheel-macos-monterey-cp313-cp313-arm64
wheel-manylinux-2-28-cp313-cp313-amd64
wheel-manylinux-2-28-cp313-cp313-arm64
wheel-musllinux-1-2-cp313-cp313-amd64
wheel-musllinux-1-2-cp313-cp313-arm64
wheel-windows-cp313-cp313-amd64

raulcd · 2026-10-28T08:27:43Z

@github-actions crossbow submit -g wheel

raulcd

@kou this is ready for review can you take a look?
None of the current failures for R are related.
I'll start preparing the milestone once this is merged.

github-actions · 2026-10-28T08:32:01Z

Revision: 7ec72cf

Submitted crossbow builds: ursacomputing/crossbow @ actions-24c5287719

Task	Status
python-sdist
wheel-macos-monterey-cp311-cp311-amd64
wheel-macos-monterey-cp311-cp311-arm64
wheel-macos-monterey-cp312-cp312-amd64
wheel-macos-monterey-cp312-cp312-arm64
wheel-macos-monterey-cp313-cp313-amd64
wheel-macos-monterey-cp313-cp313-arm64
wheel-macos-monterey-cp314-cp314-amd64
wheel-macos-monterey-cp314-cp314-arm64
wheel-macos-monterey-cp314-cp314t-amd64
wheel-macos-monterey-cp314-cp314t-arm64
wheel-macos-monterey-cp315-cp315-amd64
wheel-macos-monterey-cp315-cp315-arm64
wheel-macos-monterey-cp315-cp315t-amd64
wheel-macos-monterey-cp315-cp315t-arm64
wheel-manylinux-2-28-cp311-cp311-amd64
wheel-manylinux-2-28-cp311-cp311-arm64
wheel-manylinux-2-28-cp312-cp312-amd64
wheel-manylinux-2-28-cp312-cp312-arm64
wheel-manylinux-2-28-cp313-cp313-amd64
wheel-manylinux-2-28-cp313-cp313-arm64
wheel-manylinux-2-28-cp314-cp314-amd64
wheel-manylinux-2-28-cp314-cp314-arm64
wheel-manylinux-2-28-cp314-cp314t-amd64
wheel-manylinux-2-28-cp314-cp314t-arm64
wheel-manylinux-2-28-cp315-cp315-amd64
wheel-manylinux-2-28-cp315-cp315-arm64
wheel-manylinux-2-28-cp315-cp315t-amd64
wheel-manylinux-2-28-cp315-cp315t-arm64
wheel-musllinux-1-2-cp311-cp311-amd64
wheel-musllinux-1-2-cp311-cp311-arm64
wheel-musllinux-1-2-cp312-cp312-amd64
wheel-musllinux-1-2-cp312-cp312-arm64
wheel-musllinux-1-2-cp313-cp313-amd64
wheel-musllinux-1-2-cp313-cp313-arm64
wheel-musllinux-1-2-cp314-cp314-amd64
wheel-musllinux-1-2-cp314-cp314-arm64
wheel-musllinux-1-2-cp314-cp314t-amd64
wheel-musllinux-1-2-cp314-cp314t-arm64
wheel-musllinux-1-2-cp315-cp315-amd64
wheel-musllinux-1-2-cp315-cp315-arm64
wheel-musllinux-1-2-cp315-cp315t-amd64
wheel-musllinux-1-2-cp315-cp315t-arm64
wheel-windows-cp311-cp311-amd64
wheel-windows-cp312-cp312-amd64
wheel-windows-cp313-cp313-amd64
wheel-windows-cp314-cp314-amd64
wheel-windows-cp314-cp314t-amd64
wheel-windows-cp315-cp315-amd64
wheel-windows-cp315-cp315t-amd64

CurtHagenlocher requested review from assignUser, jonkeane, kou and raulcd as code owners October 23, 2026 23:40

Copilot AI balanced review requested due to automatic review settings October 23, 2026 23:40

github-actions Bot added Component: C++ awaiting review Awaiting review labels Oct 23, 2026

Copilot started reviewing on behalf of CurtHagenlocher October 23, 2026 23:42

View session

Copilot AI reviewed Oct 23, 2026

View reviewed changes

Comment thread ci/vcpkg/ports.patch Outdated

Copilot AI balanced review requested due to automatic review settings October 23, 2026 23:51

Copilot started reviewing on behalf of CurtHagenlocher October 23, 2026 23:52

View session

Copilot AI reviewed Oct 23, 2026

View reviewed changes

ctriley mentioned this pull request Oct 24, 2026

Mitigate CVE-2026-111497 in HTTP downloads mobility-solutions-inc/censusdis#46

Merged

rok approved these changes Oct 24, 2026

View reviewed changes

github-actions Bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Oct 24, 2026

raulcd reviewed Oct 26, 2026

View reviewed changes

github-actions Bot added awaiting changes Awaiting changes and removed awaiting merge Awaiting merge labels Oct 26, 2026

Copilot AI balanced review requested due to automatic review settings October 26, 2026 12:24

github-actions Bot added Component: GLib and removed awaiting changes Awaiting changes labels Oct 26, 2026

Copilot started reviewing on behalf of CurtHagenlocher October 26, 2026 12:24

View session

github-actions Bot added the awaiting change review Awaiting change review label Oct 26, 2026

Copilot AI reviewed Oct 26, 2026

View reviewed changes

Copilot AI balanced review requested due to automatic review settings October 27, 2026 16:45

Copilot started reviewing on behalf of CurtHagenlocher October 27, 2026 16:46

View session

github-actions Bot added the Component: R label Oct 27, 2026

CurtHagenlocher and others added 4 commits October 27, 2026 17:46

Force newer versions of Brotli

cfc67df

Patch nanoarrow's vcpkg now required by Azure SDK

180159a

github-actions Bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Oct 27, 2026

Use bundled brotli for R win binaries instead of msys2 one from rtools

b93d56b

Copilot AI reviewed Oct 27, 2026

View reviewed changes

raulcd force-pushed the newer_brotli branch from 57a8f9d to b93d56b Compare October 27, 2026 19:41

Copilot AI balanced review requested due to automatic review settings October 27, 2026 19:41

Copilot started reviewing on behalf of CurtHagenlocher October 27, 2026 19:42

View session

Copilot AI reviewed Oct 27, 2026

View reviewed changes

Try patching protobuf for MSVC to fix Windows wheels

7ec72cf

Copilot AI balanced review requested due to automatic review settings October 27, 2026 20:21

Copilot started reviewing on behalf of CurtHagenlocher October 27, 2026 20:22

View session

Copilot AI reviewed Oct 27, 2026

View reviewed changes

raulcd approved these changes Oct 28, 2026

View reviewed changes

github-actions Bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Oct 28, 2026

Conversation

CurtHagenlocher commented Oct 23, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Was AI used for this PR?

Uh oh!

github-actions Bot commented Oct 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

CurtHagenlocher commented Oct 23, 2026

Uh oh!

github-actions Bot commented Oct 23, 2026

Uh oh!

raulcd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

raulcd Oct 26, 2026

Choose a reason for hiding this comment

Uh oh!

CurtHagenlocher Oct 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

hiyasichuka commented Oct 27, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

raulcd commented Oct 27, 2026

Uh oh!

CurtHagenlocher commented Oct 27, 2026

Uh oh!

raulcd commented Oct 27, 2026

Uh oh!

github-actions Bot commented Oct 27, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

raulcd commented Oct 27, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

github-actions Bot commented Oct 27, 2026

Uh oh!

raulcd commented Oct 28, 2026

Uh oh!

raulcd left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Oct 28, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

CurtHagenlocher commented Oct 23, 2026 •

edited by github-actions Bot

Loading