Repository navigation
Conversation
Add __reduce__ for Action, Result, BasicAuth, FlightDescriptor, Ticket, Location, FlightEndpoint, SchemaResult, and FlightInfo so they round-trip through pickle (via existing serialize/deserialize, or URI for Location).
ump45nose
requested review from
AlenkaF,
lidavidm,
raulcd and
rok
as code owners
October 29, 2026 11:17
|
|
lidavidm
requested changes
Oct 29, 2026
lidavidm
left a comment
lidavidm
left a comment
Member
There was a problem hiding this comment.
Full Arrow/Flight builds were not run locally (no Flight-enabled pyarrow on this machine); relying on CI for the Python Flight job.
CI is a scarce resource, especially with the volume of PRs nowadays. The agent should be more than capable of building and testing; I'm not really willing to review if it hasn't done that much.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Fixes #35150. Flight value types such as
FlightEndpointcannot be pickled because they do not implement__reduce__, which breaks use cases that move Flight metadata across process boundaries (for example Ray).What changes are included in this PR?
Add
__reduce__for the Flight value types that already expose wire-formatserialize/deserialize(Action,Result,BasicAuth,FlightDescriptor,Ticket,FlightEndpoint,SchemaResult,FlightInfo), reducing through those helpers.Locationhas no protobuf serialize helper, so it reduces via its URI.Are these changes tested?
Added
test_pickle_flight_typesnext to the existing serialize round-trip coverage inpython/pyarrow/tests/test_flight.py. Full Arrow/Flight builds were not run locally (no Flight-enabled pyarrow on this machine); relying on CI for the Python Flight job.Are there any user-facing changes?
No breaking API changes. Pickling Flight value types that previously failed now works.
Was AI used for this PR?
In accordance to the AI generation guidelines, please disclose below whether and how AI was used in this PR.
PR code and description written by:
Reviewed before submission by: