Repository navigation
Conversation
…DBC Windows builds The ODBC Windows action checked out microsoft/vcpkg at HEAD and never applied ci/vcpkg/ports.patch. Since apacheGH-55165 bumped vcpkg, protobuf v36.2 requires our fix-msvc-global-empty-string.patch to link with C++20 code on MSVC. Use ci/scripts/install_vcpkg.sh so the vcpkg version from .env is used and the patches are applied. Because we use manifest mode, also register the patched ports as overlay ports so vcpkg actually uses them.
|
|
Member
Author
|
I think the "AMD64 Debian SIMD Level None" failure is a real issue but unrelated to this PR. Maybe related to #54905. |
alinaliBQ
self-requested a review
October 29, 2026 17:23
Member
Right! The scheduled C++ Extra on main started failing for AMD64 Debian SIMD Level NONE 2 days ago. All C++ Extra jobs were green 3 days ago. (Here's a hypothetical draft PR #55319 as exploratory static linking fix post-#54905. fyi @raulcd) But failing JNI ubuntu-24.04-arm arm64/v8 is new! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?
No.
Was AI used for this PR?
In accordance to the AI generation guidelines, please disclose below whether and how AI was used in this PR.
PR code and description written by:
Reviewed before submission by: