Skip to content

use ConfigKeys for event bus settings - #14471

Open
DaanHoogland wants to merge 1 commit into
ghi10752-config-foundationfrom
ghi10752-config-event-bus
Open

DaanHoogland wants to merge 1 commit into
ghi10752-config-foundationfrom
ghi10752-config-event-bus

Conversation

@DaanHoogland

Copy link
Copy Markdown
Contributor

Description

Switches the event bus publishing settings (action, alert and usage events) to ConfigKeys.

Part 5 of 12 of the split of #13884 (phase out the deprecated Config enum, #10752). Base: ghi10752-config-foundation. Independent of the other PRs based on the foundation, so it can be reviewed and merged in any order relative to them; GitHub retargets it to main once the foundation is merged.

Size: 5 files, +11/-30.

Split overview: foundation → parallel PRs (account, vpn-vpc, snapshot-usage, event-bus, literals) + stacked core-1 … core-5 → enum-removal (last).

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Local verification: full reactor build (checkstyle included) and the unit tests of every touched module pass on this branch; merging all PRs of the split in any order gives no conflicts and reproduces #13884 plus its fixes.

🤖 Generated with Claude Code

@codecov

codecov Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 3.88%. Comparing base (c800b90) to head (7d105be).

❗ There is a different number of reports uploaded between BASE (c800b90) and HEAD (7d105be). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (c800b90) HEAD (7d105be)
unittests 1 0
Additional details and impacted files
@@                        Coverage Diff                        @@
##             ghi10752-config-foundation   #14471       +/-   ##
=================================================================
- Coverage                         20.69%    3.88%   -16.82%     
=================================================================
  Files                              6508      493     -6015     
  Lines                            591033    42571   -548462     
  Branches                          72448     8069    -64379     
=================================================================
- Hits                             122341     1653   -120688     
+ Misses                           455417    40687   -414730     
+ Partials                          13275      231    -13044     
Flag Coverage Δ
uitests 3.88% <ø> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

🔴 Test Coverage Grade: D — Marginal

Metric Value
Line coverage 25.53%
Branch coverage 19.80%

Grade Scale

Grade Line Coverage Meaning
🟢 A ≥ 80% Excellent - this code sleeps well at night 😴
🟡 B 60-79% Good - almost there, don't stop now 😉
🟠 C 40-59% Acceptable - your code is wearing a seatbelt, but no airbags 😬
🔴 D 20-39% Marginal - boldly shipping where no test has gone before 🖖
⛔ F < 20% Failing - tests? what tests? 🔥

Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run

@DaanHoogland DaanHoogland mentioned this pull request Oct 23, 2026
3 of 14 tasks
@DaanHoogland
DaanHoogland force-pushed the ghi10752-config-foundation branch from 86803e8 to c800b90 Compare October 27, 2026 11:36
@github-actions

Copy link
Copy Markdown

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

Part of the split of #13884 (phase out the Config enum, #10752).

Co-Authored-By: Claude Opus 5.5 <[email protected]>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant