Repository navigation
PostgreSQL: parse DROP GROUP - #2712
Open
LucaCappelletti94 wants to merge 3 commits into
Open
LucaCappelletti94 wants to merge 3 commits into
LucaCappelletti94 wants to merge 3 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2712 +/- ##
==========================================
+ Coverage 82.30% 82.31% +0.01%
==========================================
Files 42 42
Lines 35307 35317 +10
Branches 35307 35317 +10
==========================================
+ Hits 29058 29072 +14
+ Misses 2691 2687 -4
Partials 3558 3558 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
LucaCappelletti94
force-pushed
the
pg-drop-group
branch
3 times, most recently
from
October 26, 2026 18:58
0214e6a to
10c2655
Compare
LucaCappelletti94
force-pushed
the
pg-drop-group
branch
from
October 26, 2026 20:18
10c2655 to
5427133
Compare
sabir-akhadov-localstack
approved these changes
Oct 27, 2026
| } else { | ||
| return self.expected_ref( | ||
| "COLLATION, CONNECTOR, DATABASE, EXTENSION, FUNCTION, INDEX, OPERATOR, POLICY, PROCEDURE, ROLE, SCHEMA, SECRET, SEQUENCE, STAGE, TABLE, TRIGGER, TYPE, VIEW, MATERIALIZED VIEW, USER or WAREHOUSE after DROP", | ||
| "COLLATION, CONNECTOR, DATABASE, EXTENSION, FUNCTION, GROUP, INDEX, OPERATOR, POLICY, PROCEDURE, ROLE, SCHEMA, SECRET, SEQUENCE, STAGE, TABLE, TRIGGER, TYPE, VIEW, MATERIALIZED VIEW, USER or WAREHOUSE after DROP", |
Contributor
There was a problem hiding this comment.
Non-blocking: on dialects without supports_drop_group this now reads Expected: ... GROUP, ... after DROP, found: GROUP (the gated test asserts exactly that). Listing GROUP only when the dialect supports it would avoid the contradiction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQL accepts
DROP GROUP [IF EXISTS] name [, ...]as an alias forDROP ROLE.Sliced out of #2429 to minimize size of both PRs, although they will have some collisions and need a rebase since they are in older external branches and I could not stack them.
PostgreSQL syntax reference https://www.postgresql.org/docs/current/sql-dropgroup.html