Repository navigation
PostgreSQL: Parse untyped column entries in CREATE TABLE ... PARTITION OF - #2766
Open
LucaCappelletti94 wants to merge 3 commits into
Open
LucaCappelletti94 wants to merge 3 commits into
LucaCappelletti94 wants to merge 3 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2766 +/- ##
==========================================
+ Coverage 82.61% 82.62% +0.01%
==========================================
Files 42 42
Lines 35614 35633 +19
Branches 35614 35633 +19
==========================================
+ Hits 29421 29442 +21
Misses 2659 2659
+ Partials 3534 3532 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
LucaCappelletti94
force-pushed
the
upstream/partition-of-untyped-columns
branch
2 times, most recently
from
October 30, 2026 07:47
ee786a6 to
717d46f
Compare
LucaCappelletti94
force-pushed
the
upstream/partition-of-untyped-columns
branch
3 times, most recently
from
October 30, 2026 17:33
141a4e6 to
1e4daab
Compare
LucaCappelletti94
force-pushed
the
upstream/partition-of-untyped-columns
branch
from
October 30, 2026 22:25
1e4daab to
947917f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
CREATE TABLE ... PARTITION OF, a column entry iscolumn_name [ WITH OPTIONS ] [ column_constraint ... ]and carries no data type (https://www.postgresql.org/docs/current/sql-createtable.html). The parser always read a type there, so(id NOT NULL)became a column of typeNOTwith aNULLoption, and(id)or(id DEFAULT 0)failed to parse.In the
PARTITION OFform, column entries now parse withDataType::Unspecified, the shape SQLite's untyped columns already use.WITH OPTIONSis a noise word that PostgreSQL's own parse tree also discards, so it is accepted and dropped like[ COLUMN ]inALTER TABLE. A data type in this position is now rejected, as PostgreSQL rejects it.Thanks to @s5dsn-eqee for spotting this one.
Closes #2762.