Repository navigation
refactor: Centralize CI command definitions in xtask - #26765
Merged
Merged
Conversation
# Conflicts: # xtask/src/ci_steps.rs
alamb
approved these changes
Oct 30, 2026
alamb
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me -- I tried it out locally
cargo xtask ci step test cliandrewlamb@Andrews-MacBook-Pro-3:~/Software/datafusion$ cargo xtask ci step check --help
DataFusion CI command: check
Check workspace or package compilation
Usage:
cargo xtask ci step check <workspace|package> [default|no-default|feature] [--explain]
Examples:
cargo xtask ci step check workspace
cargo xtask ci step check datafusion default
Use '--explain' to show the full command:
cargo xtask ci step check workspace --explain| } | ||
| } | ||
|
|
||
| impl CommandSpec { |
Contributor
There was a problem hiding this comment.
i wn't say I followed all this implementation, but I skimmed it all and it is pretty neat
Contributor
|
I also took the liberty of merging up from main to resolve a merge conflict |
Contributor
Author
|
@alamb Thanks for the review. |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 31, 2026
Contributor
Author
|
The failing fuzzing UT uses different seed in each run. https://github.com/apache/datafusion/actions/runs/41196052207/job/124522323666 I'll capture the failing case and open an issue later. Now retry merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Introduce a centralized struct
CommandSpecfor individualxtaskcommands.This Keep each step’s environment, prerequisites, and documentation alongside its command, and it can make maintenance easier, and also easier to use: running with
--explainshows docs, prerequisites, etc. for this command.Demo
The default rust test in CI run this command
datafusion/.github/workflows/rust.yml
Line 467 in 350ca76
And we can run it locally, and also use
--explainto show required dependencies, envvars, documentations. (now it only has required dependency, envar. Documentations for this specific commands can be add later)What changes are included in this PR?
Key changes are:
CommandSpecWhat is the testing strategy for this PR?
UTs, also CI run itself
Are there any user-facing changes?