Skip to content

Prefer for loops over parametrized tests in AGENTS.md #4150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevinjqliu merged 2 commits into from
Oct 25, 2026
Merged

Prefer for loops over parametrized tests in AGENTS.md #4150

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93e6be0
Prefer for loops over parametrized tests in AGENTS.md
kevinjqliu Oct 24, 2026
3af1a3e
Simplify parametrize guidance in AGENTS.md
kevinjqliu Oct 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ lives under `pyiceberg/`, organized by concern rather than by engine:
- Bias towards adding tests to existing files, rather than creating new files.
- Use existing test fixtures when possible.
- We have a strong bias towards integration testing over mocks. Mocks should be avoided whenever possible and should only be used if similar, existing tests are using mocks.
- Prefer a `for` loop over `@pytest.mark.parametrize` for many simple cases; each parametrized case adds per-test overhead. Use `parametrize` when cases need different fixtures, and separate tests when cases are complex.

### Required CI and Merge Queue

Expand Down
Loading