Skip to content

Parse adls.anon as a boolean in FsspecFileIO #4154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kevinjqliu wants to merge 1 commit into from
Closed

Parse adls.anon as a boolean in FsspecFileIO #4154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyiceberg/io/fsspec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ async def get_token(self, *scopes: str, **kwargs: Any) -> AccessToken:
client_id=properties.get(ADLS_CLIENT_ID),
client_secret=properties.get(ADLS_CLIENT_SECRET),
account_host=properties.get(ADLS_ACCOUNT_HOST),
anon=properties.get(ADLS_ANON),
anon=property_as_bool(properties, ADLS_ANON, False) if properties.get(ADLS_ANON) not in (None, "") else None,
)


Expand Down
16 changes: 16 additions & 0 deletions tests/io/test_fsspec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -756,6 +756,22 @@ def test_adls_account_name_not_overridden_when_in_properties() -> None:
)


def test_adls_anon_parsed_as_bool() -> None:
cases: list[tuple[Properties, bool | None]] = [
({"adls.anon": "false"}, False),
({"adls.anon": "true"}, True),
({"adls.anon": False}, False),
({"adls.anon": True}, True),
({}, None),
]
for properties, expected in cases:
with mock.patch("adlfs.AzureBlobFileSystem") as mock_adlfs:
adls_fileio = FsspecFileIO(properties=properties)
adls_fileio.new_input(location="abfss://[email protected]/wh/t/a.parquet")

assert mock_adlfs.call_args.kwargs["anon"] is expected


@pytest.mark.gcs
def test_fsspec_new_input_file_gcs(fsspec_fileio_gcs: FsspecFileIO) -> None:
"""Test creating a new input file from a fsspec file-io"""
Expand Down
Loading