Repository navigation
chore: use StrEnum for the four enums that subclass str - #4180
Merged
Merged
Conversation
Python 3.11 added enum.StrEnum, and ruff's UP042 (preview) asks for it. HttpMethod, FileFormat, IsolationLevel and SnapshotRefType all qualify. SnapshotRefType.__str__ goes away because StrEnum already returns the value. For the other three, str() and f-strings now render the value instead of the class-qualified name, so FileFormat.AVRO prints as AVRO where it used to print as FileFormat.AVRO. repr() keeps the class name, and the values, equality, hashing and JSON output are unchanged. No code or test in the repository relied on the old strings.
Fokko
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Python 3.11 introduce the native StrEnum class, so I used Ruff's UP042 to convert the four existing enums that subclass
str, so theSnapshotRefType.__str__method becomes redundant (in one of them), the rest are simple swapsWhy
Modernizing and simplifying the codebase
Tests
Tested with
make lintand the unit suites