Repository navigation
MINOR: [1.18.x] Upgrade Thrift to 0.25.0 - #3891
Merged
Fokko merged 1 commit intoOct 27, 2026
Merged
Conversation
Backport the relevant parts of apache#3855 directly from 0.23.0 to 0.25.0. Update the runtime and compiler together, align CI and build instructions, and implement the transport reset method required by Thrift 0.25.0. (cherry picked from commit b97860d) Co-authored-by: Codex <[email protected]>
divjotarora
approved these changes
Oct 27, 2026
Fokko
approved these changes
Oct 27, 2026
Fokko
left a comment
Fokko
left a comment
Contributor
There was a problem hiding this comment.
Nice, this also simplifies the validation because brew install apache-thrift installs the latest 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Backport #3855 to
parquet-1.18.xso 1.18.2 includes Apache Thrift 0.25.0 security fixes. The branch currently uses 0.23.0, including the shaded runtime inparquet-format-structures.Apache's security announcement: https://www.openwall.com/lists/oss-security/2026/10/04/1
What changes are included in this PR?
StubTTransport.resetMessageSizeAndConsumedBytes(long), required by the new Thrift API.Adapted from
b97860d7(#3855). The maintenance branch has no developer Docker image; unrelated Maven-wrapper changes from the original PR are omitted.Are these changes tested?
verifyforparquet-thriftand its dependencies with Thrift compiler 0.25.0: 261 tests, 0 failures/errors, 2 existing disabled array-compatibility tests.parquet-thrifttests and focused metadata, message-size, encryption, Parquet reader/writer tests.git diff --checkand CI script syntax check passed.Broad integration tests and Javadocs were skipped.
Are there any user-facing changes?
Builds require Thrift compiler 0.25.0. The runtime includes stricter validation for malformed input; the required
libthriftversion forparquet-thriftis updated. No Parquet file-format or public Parquet API change is introduced.