Repository navigation
Conversation
Backport apache#3851 and apache#3865 as a direct upgrade from 1.1.10.8. Includes the input-validation security fixes and subsequent Hadoop ByteBuffer compatibility corrections. (cherry picked from commit 72abdcc) (cherry picked from commit db9e610) Co-authored-by: Codex <[email protected]>
divjotarora
approved these changes
Oct 27, 2026
Fokko
approved these changes
Oct 27, 2026
Fokko
left a comment
Fokko
left a comment
Contributor
There was a problem hiding this comment.
Thanks for fixing this @manuzhang
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Backport #3851 and #3865 to
parquet-1.18.xso 1.18.2 includes Snappy's input-validation security fixes and the subsequent Hadoop compatibility corrections. The branch currently uses snappy-java 1.1.10.8.Upstream security changes: xerial/snappy-java#739
What changes are included in this PR?
Upgrade
org.xerial.snappy:snappy-javadirectly from 1.1.10.8 to 1.1.10.12 inparquet-hadoop/pom.xml. This combines the two main-branch upgrades in one maintenance commit. It is independent of the Thrift upgrade.Are these changes tested?
parquet-hadoopreactorverify, using the branch's unchanged Thrift 0.23.0 compiler/runtime: 99 tests, 0 failures/errors/skips.TestSnappyCodec,TestCompressionCodec,TestDirectCodecFactory,TestParquetWriter,TestParquetReader, andTestDataPageChecksums.git diff --checkpassed.Broad integration tests and Javadocs were skipped.
Are there any user-facing changes?
Snappy rejects malformed inputs and unsafe buffer sizes earlier. The selected version includes the later Hadoop ByteBuffer/header compatibility fixes. No Parquet file-format change is introduced.