Repository navigation
Conversation
ProtoSchemaConverter used ImmutableSetMultimap only to track which message types were seen at which recursion depth. Replace it with an immutable Map<String, Set<Integer>> that is copied on add, so sibling branches still don't see each other's entries. The Guava dependency stays at compile scope: elephant-bird-core, which parquet-protobuf uses at runtime, depends on Guava and would otherwise resolve to its very old Guava 11.0.1 for downstream users. Co-authored-by: Isaac <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
ProtoSchemaConverterwas the only main-code Guava user in parquet-protobuf. It usedImmutableSetMultimaponly to track which message types were seen at which recursion depth.What changes are included in this PR?
Replace it with an immutable
Map<String, Set<Integer>>that is copied on add, so sibling branches still don't see each other's entries.The Guava dependency stays at compile scope on purpose:
elephant-bird-core, which parquet-protobuf uses at runtime, depends on Guava. Making it test scope would make downstream users resolve elephant-bird's Guava 11.0.1. Next step is to removeelephant-bird, since it is unmaintained for a long time.Are these changes tested?
Covered by the existing parquet-protobuf tests, including the recursion tests (
ProtoRecursionTruncationTest,ProtoSchemaConverterTest).Are there any user-facing changes?
No.
Closes #3899
This pull request and its description were written by Isaac.