Repository navigation
GH-3901: Use StandardCharsets and Objects instead of legacy helpers - #3907
Merged
Merged
Conversation
…pers Point the deprecated BytesUtils.UTF8 and PlainValuesWriter.CHARSET constants at StandardCharsets.UTF_8 and document the replacement. Replace "UTF-8" charset lookups in tests with StandardCharsets.UTF_8, and use Objects.requireNonNull in SnappyUtil instead of the deprecated Preconditions.checkNotNull. Co-authored-by: Isaac <[email protected]>
wgtmac
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
A few places still used
Charset.forName("UTF-8")or the deprecatedPreconditions.checkNotNull.What changes are included in this PR?
BytesUtils.UTF8andPlainValuesWriter.CHARSETare nowStandardCharsets.UTF_8, andPlainValuesWriter.CHARSETgets a@deprecatedpointer to it.StandardCharsets.UTF_8instead of"UTF-8"strings.SnappyUtilusesObjects.requireNonNull.Are these changes tested?
Covered by the existing tests.
Are there any user-facing changes?
No. The constants keep their type and value.
Closes #3901
This pull request and its description were written by Isaac.