Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1207 +/- ##
==========================================
+ Coverage 93.09% 93.50% +0.40%
==========================================
Files 54 54
Lines 3708 3710 +2
==========================================
+ Hits 3452 3469 +17
+ Misses 256 241 -15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vdusek
marked this pull request as draft
October 26, 2026 07:36
vdusek
marked this pull request as ready for review
October 26, 2026 14:02
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In shared mode,
fetch_next_requestreturnedNonewhenget_requestcouldn't find a request thatlist_and_lock_headhad just locked. It also removed the ID from the local queue head but kept the 3-minute platform lock. Later head listings skip locked requests, so neither this client nor any other consumer could fetch the request until the lock expired.This showed up as a flake of
test_shared_is_finished_false_while_request_in_progress(run). It polledfetch_next_requestfor 30 s and never got the request. #1105 added that polling, but polling can't get past a 3-minute lock.Both not-found paths now put the ID back on the local queue head, so the next fetch retries it. If the request never shows up, the lock check in
_ensure_lock_windowdrops it, so it isn't retried forever. Two unit tests cover the paths: the plain cache hit, and a request evicted from the cache.✍️ Drafted by Claude Code