Skip to content

fix(deps): drop the upper bound on sqlalchemy - #2356

Merged
vdusek merged 1 commit into
masterfrom
fix/uncap-sqlalchemy
Oct 26, 2026
Merged

vdusek merged 1 commit into
masterfrom
fix/uncap-sqlalchemy

Conversation

@vdusek

@vdusek vdusek commented Oct 26, 2026

Copy link
Copy Markdown
Collaborator

Removes the <3.0.0 cap on sqlalchemy from the sql_postgres, sql_sqlite and sql_mysql extras. There is no known incompatibility behind it, and downstream users can't override a cap in published metadata, so it can only cause resolver conflicts. If a future SQLAlchemy release breaks us, CI will show it and we can exclude that version.

The stagehand<4 cap stays, since it guards a known breaking API change.

Background: https://iscinumpy.dev/post/bound-version-constraints/

✍️ Drafted by Claude Code

@vdusek vdusek added t-tooling Issues with this label are in the ownership of the tooling team. adhoc Ad-hoc unplanned task added during the sprint. labels Oct 26, 2026
@vdusek vdusek self-assigned this Oct 26, 2026
@vdusek
vdusek requested a review from Pijukatel October 26, 2026 08:14
@codecov

codecov Bot commented Oct 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.12%. Comparing base (cd6f748) to head (71d2792).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2356      +/-   ##
==========================================
- Coverage   94.13%   94.12%   -0.01%     
==========================================
  Files         184      184              
  Lines       13647    13647              
==========================================
- Hits        12846    12845       -1     
- Misses        801      802       +1     
Flag Coverage Δ
unit 94.12% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Pijukatel
Pijukatel requested review from Mantisus and removed request for Pijukatel October 26, 2026 09:20

@Mantisus Mantisus left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apify-approval-mirror apify-approval-mirror Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mirroring approval from @Mantisus.

@vdusek
vdusek merged commit cadd810 into master Oct 26, 2026
48 of 50 checks passed
@vdusek
vdusek deleted the fix/uncap-sqlalchemy branch October 26, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants