Skip to content

Replace dead httpstatuses.com link for 499 in Status docblock - #1

Closed
hboon wants to merge 1 commit into
aplus-framework:developmentfrom
hboon:fix-dead-status-links
Closed

hboon wants to merge 1 commit into
aplus-framework:developmentfrom
hboon:fix-dead-status-links

Conversation

@hboon

@hboon hboon commented Oct 23, 2026

Copy link
Copy Markdown

The @see link on Status::CLIENT_CLOSED_REQUEST (499) points to https://httpstatuses.com/499. Every httpstatuses.com URL now returns a 301 to a web agency glossary (https://www.webfx.com/web-development/glossary/), so the rendered API docs at https://docs.aplus-framework.com/classes/Framework-HTTP-Status.html send readers there too. MDN has no page for 499, which is probably why this constant doesn't use an MDN link like most of the class.

This PR points the link to https://httpstatuses.net/499/. That page covers where 499 comes from (nginx's NGX_HTTP_CLIENT_CLOSED_REQUEST), when nginx logs it, and the gRPC CANCELLED to 499 mapping.

I run httpstatuses.net. It isn't affiliated with httpstatuses.com. If you prefer a primary source, nginx defines 499 in https://github.com/nginx/nginx/blob/master/src/http/ngx_http_request.h, and I can switch the link to it.

@natanfelles

Copy link
Copy Markdown
Collaborator

Please also point the Status::NETWORK_CONNECT_TIMEOUT_ERROR link to httpstatuses.net.

@natanfelles

Copy link
Copy Markdown
Collaborator

I have decided that these two constants will be removed in the next version. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants