Repository navigation
fix(options): type wait_for_quiescence setter as bool - #1344
Merged
KazuCocoa merged 1 commit intoOct 31, 2026
Merged
Conversation
waitForQuiescence is a boolean XCUITest capability and the getter returns bool, but the setter was annotated as accepting timedelta | float, copied from the timeout options. Type checkers therefore accepted a timedelta, which cannot be serialized when the session is created. Annotate the setter as bool and drop the unused timedelta import. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01K6zVKi1DtwmmBpy16MQyfY
KazuCocoa
approved these changes
Oct 31, 2026
KazuCocoa
left a comment
KazuCocoa
left a comment
Member
There was a problem hiding this comment.
waitForQuiescence no longer exists, thus we'll clean up these later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
waitForQuiescenceis a boolean XCUITest capability, andXCUITestOptions.wait_for_quiescenceis annotated to returnbool | None. Its setter, however, was annotated asvalue: timedelta | float, which looks copied from the neighbouring timeout options such aswait_for_idle_timeout.As a result, type checkers accepted
options.wait_for_quiescence = timedelta(seconds=1). That value is stored unchanged and cannot be serialized when the session is created.Fix
Annotate the setter as
value: bool, consistent with the getter and with the other boolean options such asauto_accept_alerts. Remove thetimedeltaimport, which is now unused. There is no runtime change.Tests
options.wait_for_quiescence = timedelta(seconds=1)and still acceptsoptions.wait_for_quiescence = False.ruff check,ruff format --check,mypy appiumand the full unit test suite pass.🤖 Generated with Claude Code