Repository navigation
fix: bump vulnerable dependencies to patched versions - #167
Merged
Merged
Conversation
black 25.11.0 is affected by GHSA-3936-cmfr-pm3m. Black 26 needs Python 3.10, so the test extra skips it on 3.9.
🟢 Tier S · Ready to merge
The test extra now pins Black 26.10.1 for Python 3.10 and newer, avoiding installation of a Black version that does not support the SDK's Python 3.9 minimum. Other test dependencies are unchanged.
📂 Walkthrough · 1
Reviewed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Dependabot alert #4 (GHSA-3936-cmfr-pm3m, high): black before 26.3.1 builds its cache file name from unsanitized user input, allowing arbitrary file writes. black is only a development dependency in the
testextra.Black 26 requires Python 3.10, while this SDK still supports 3.9, so the pin carries a
python_version >= '3.10'marker. Installing.[test]on 3.9 still works, it just skips black. 26.10.1 is the version the sdk-generator validation workflow already uses.This file is generated from
templates/python/pyproject.toml.twigin appwrite/sdk-generator, which gets the same change in a companion PR so the next generation does not revert it.Verification
pip install -e .[test]on Python 3.12 and 3.9: both succeed (3.9 skips black)black --checkoverappwrite,testandsetup.pywith 26.10.1: no changes neededpython -m compileall appwrite/: passespython -m unittest: 977 tests, OKpip-audit --strict .: no known vulnerabilities