Skip to content

Propagate archetype install failures #1718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sean0407 wants to merge 1 commit into
base: main
Choose a base branch
from
+60 −1
Open

Propagate archetype install failures #1718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion gha_build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ function archetype {
ARCHETYPE_NAME=aws-serverless-$1-archetype
PROJ_NAME=$1-archetype-test
cd ${WORKING_DIR}/${ARCHETYPE_NAME} && mvn -q clean install
if [[ "$?" -ne 0 ]]; then
exit 1
fi
ARCHETYPE_TEST_DIR=${WORKING_DIR}/$1_archetype_test
mkdir -p ${ARCHETYPE_TEST_DIR}
cd ${ARCHETYPE_TEST_DIR} && mvn archetype:generate -DgroupId=my.service -DartifactId=${PROJ_NAME} -Dversion=2.0-SNAPSHOT \
Expand Down Expand Up @@ -86,4 +89,4 @@ if [[ "$RUN_ARCHETYPE" = true ]] ; then
fi
if [[ "$RUN_SAMPLES" = true ]] ; then
sample ${FRAMEWORK}
fi
fi
56 changes: 56 additions & 0 deletions tests/gha_build_archetype_failure_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
#!/usr/bin/env bash
set -euo pipefail

REPO_ROOT=$(cd "$(dirname "$0")/.." && pwd)
TEST_ROOT=$(mktemp -d)
trap 'rm -rf "$TEST_ROOT"' EXIT

FIXTURE="$TEST_ROOT/project"
BIN="$TEST_ROOT/bin"
mkdir -p "$FIXTURE" "$BIN"
cp "$REPO_ROOT/gha_build.sh" "$FIXTURE/gha_build.sh"
mkdir -p \
"$FIXTURE/aws-serverless-java-container-core" \
"$FIXTURE/aws-serverless-java-container-spring" \
"$FIXTURE/aws-serverless-spring-archetype"

cat > "$BIN/mvn" <<'MAVN'
#!/usr/bin/env bash
set -euo pipefail
printf '%s\t%s\n' "$PWD" "$*" >> "$MAVEN_LOG"

if [[ "$PWD" == "$FIXTURE/aws-serverless-spring-archetype" && "$*" == "-q clean install" ]]; then
exit 23
fi

if [[ "$*" == *archetype:generate* ]]; then
mkdir -p "$PWD/spring-archetype-test"
cat > "$PWD/spring-archetype-test/gradlew" <<'GRADLEW'
#!/usr/bin/env bash
exit 0
GRADLEW
chmod +x "$PWD/spring-archetype-test/gradlew"
fi
MAVN
cat > "$BIN/gradle" <<'GRADLE'
#!/usr/bin/env bash
exit 0
GRADLE
chmod +x "$BIN/mvn" "$BIN/gradle"

export FIXTURE MAVEN_LOG="$TEST_ROOT/maven.log"
set +e
(cd "$FIXTURE" && PATH="$BIN:$PATH" bash ./gha_build.sh spring true false)
status=$?
set -e

if [[ $status -eq 0 ]]; then
echo "gha_build.sh returned success after archetype mvn clean install failed" >&2
exit 1
fi
if grep -q 'archetype:generate' "$MAVEN_LOG"; then
echo "archetype generation ran after the archetype install failed" >&2
exit 1
fi

echo "archetype install failure propagated before generation (exit $status)"