Repository navigation
Share the redirect origin check, NEWS for #978 and #979 - #986
Merged
Merged
Conversation
hackney.erl and hackney_h3.erl each had their own same_origin/2; both redirect paths now use hackney_url:same_origin/2. The test-only export of maybe_strip_auth_on_redirect/3 is gone: the origin cases are unit tests on hackney_url, and location_trusted is covered end to end.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #979. The HTTP/1.1 and HTTP/2 redirect path and the HTTP/3 one each had their own copy of the origin check; both now use
hackney_url:same_origin/2. The test-only export #979 added tohackney.erlis removed: the origin cases move tohackney_urlunit tests, andlocation_trustedgets an end-to-end redirect test.Also adds the NEWS entries for #978 and #979, including the stricter trust behaviour when pinned
cacertsinclude public roots. No behaviour change.