Repository navigation
Refuse CR/LF/NUL in the proxy_auth_fun result - #989
Merged
Merged
Conversation
The callback's value was written as is into the Proxy-Authorization line of the CONNECT retry, so CR/LF in it added header lines. Every other caller-supplied header is already stripped or refused.
benoitc
force-pushed
the
fix/proxy-auth-header-ctl
branch
from
October 25, 2026 21:02
b09a0bc to
5ee7d7d
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a 407, the value returned by
proxy_auth_funwas written as is into theProxy-Authorizationline of the CONNECT retry. CR or LF in it added header lines of their own to the request sent to the proxy. Every other caller-supplied value on the request path is already stripped or refused (hackney_headers, the CONNECT target host).Such a value is now refused with
{error, {proxy_auth_error, invalid_header}}before anything is sent.Reported by manus-pi (GHSA-465p-49rx-v264).