Repository navigation
Conversation
This is a known bug we've had for quite some time. Basically, we were checking `prefix.length` to calculate how much space the prefix (e.g. the guide) takes up. This is incorrect since the prefix usually contains escape sequences, so it can be off by several characters. Using fast-string-width instead means we get the actual width. Note that fast-string-width is already a deep dependency, so this just declares it at the root.
🦋 Changeset detectedLatest commit: 3cdb798 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a known bug we've had for quite some time. Basically, we were
checking
prefix.lengthto calculate how much space the prefix (e.g.the guide) takes up.
This is incorrect since the prefix usually contains escape sequences, so
it can be off by several characters. Using fast-string-width instead
means we get the actual width.
Note that fast-string-width is already a deep dependency, so this just
declares it at the root.
As part of this, I also wrapped the footer of select-like prompts FYI.
Type of change
Checklist
pnpm testpasses (or targeted tests for my change)pnpm formathas been runAI-generated code disclosure