Repository navigation
test(store): build the frozen reader's nonce with TryFrom (LAB-11846) - #43
Merged
Merged
Conversation
aes-gcm 0.11 deprecates Nonce::from_slice in favour of TryFrom, and CI denies warnings, so clippy failed on the test-only AES-GCM reader.
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Providing Context (Files & MCPs)Add these hints in your PR description (or a comment) to unlock deeper checks:
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aes-gcm 0.11 (dev-dependency) deprecates
Nonce::from_slicein favour ofTryFrom. CI runs clippy with-D warnings, so thechecksjob has failed onmainsince the bump.This changes only the
#[cfg(test)]frozen reader insrc/store.rs: the nonce is built withtry_into().split_at_checked(12)?already guarantees 12 bytes, and.ok()?fitsopen'sOptionreturn. No shipped code changes, and no#[allow(deprecated)].Local:
cargo clippy --locked --all-targets -- -D warningsclean,cargo fmt --checkclean,cargo test --lockedpasses (store: 6 of 6, assertions unchanged).Closes LAB-11846