Skip to content

test(store): build the frozen reader's nonce with TryFrom (LAB-11846) - #43

Merged
27Bslash6 merged 1 commit into
mainfrom
lab-11846-aes-gcm-nonce-tryfrom
Oct 29, 2026
Merged

27Bslash6 merged 1 commit into
mainfrom
lab-11846-aes-gcm-nonce-tryfrom

Conversation

@27Bslash6

Copy link
Copy Markdown
Contributor

aes-gcm 0.11 (dev-dependency) deprecates Nonce::from_slice in favour of TryFrom. CI runs clippy with -D warnings, so the checks job has failed on main since the bump.

This changes only the #[cfg(test)] frozen reader in src/store.rs: the nonce is built with try_into(). split_at_checked(12)? already guarantees 12 bytes, and .ok()? fits open's Option return. No shipped code changes, and no #[allow(deprecated)].

Local: cargo clippy --locked --all-targets -- -D warnings clean, cargo fmt --check clean, cargo test --locked passes (store: 6 of 6, assertions unchanged).

Closes LAB-11846

aes-gcm 0.11 deprecates Nonce::from_slice in favour of TryFrom, and CI
denies warnings, so clippy failed on the test-only AES-GCM reader.
@kodus-27b

kodus-27b Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Code Review Completed! 🔥

The code review was successfully completed based on your current configurations.

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the `@kody start-review` command at the root of your PR.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Providing Context (Files & MCPs)

Add these hints in your PR description (or a comment) to unlock deeper checks:

  • Ticket / Acceptance Criteria: `Refs: ABC-123` (Linear/Jira/Asana/ClickUp/Trello) or a direct ticket link.
  • Bugfix Validation: a Sentry/Datadog/Bugsnag event link (or paste the stack trace/error message).
  • Endpoint Risk: mention the route (e.g., `POST /api/payments`) or controller/action name.
  • Attach a repo file as context: use an explicit marker like `@file:docs/guide.mdx#L10-L50` (replace with your real path).
  • API Contract Docs: include `@file:openapi.yaml` or `@file:swagger.json` when changing routes/schemas.
  • Definition of Done / Standards: include `@file:DOD.md` or `@file:CONTRIBUTING.md` if your repo has them.
  • Design System Source of Truth: include `@file:ui/index.ts` (replace with your DS entrypoint path).
  • Feature Flags: include the flag key/name and `@file:flags.ts` / `@file:config.json` (and optionally the PostHog flag name).
  • Edge/CDN Rules: link the Cloudflare rule/zone or describe the intended redirect/header behavior.
  • Attach an MCP tool output: use `@mcp<provider|tool>` (replace with an installed MCP provider + tool, e.g., `@mcp<sentry|events.search>`).
Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug ✅
Performance ✅
Security ✅
Business Logic ✅

Access your configuration settings here.

@27Bslash6
27Bslash6 merged commit 52c6188 into main Oct 29, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant