Repository navigation
fix(list): expand accordion with id 0 in a controlled AccordionGroup - #5145
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
Found potential problems with the pull request:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
A controlled
List.AccordionGroupwithexpandedId={0}does not expand the accordion withid={0}. The group resolves the expanded ID withexpandedIdProp || expandedId, so0falls back to the internal state, which a controlled group never updates. Indexes from.mapare a common source of IDs, so the first accordion in such a list can never be opened.This change uses
??so onlyundefinedfalls back to the internal state. Uncontrolled groups behave as before.Related issue
id={0}support was added in #3936 (fixing #3902), but the controlledexpandedIdpath still treats0as missing. Fixes #5144Screenshots / Videos
Not applicable. The change affects which accordion expands, not styling.
Test plan
Render a controlled group:
Confirm that "First" is expanded on mount.
Press "Second", then press "First" again, and confirm that "First" expands.