Repository navigation
fix(dev-server): pass request log suppression via fastify logController - #1513
Merged
Merged
Conversation
Fastify 5.12 deprecates the top-level disableRequestLogging option (FSTDEP023). The dev server always passed a concrete boolean derived from logRequests, so the warning printed on every start. Pass it through a LogController instance instead; the logger stream is unchanged.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 2bd48c7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every dev server start prints:
Fastify warns whenever
options.disableRequestLogging !== undefined, and the dev server always passes a boolean derived fromlogRequests, so it fired for everyone.This passes the same value through a
LogControllerinstance instead:LogControllerinstance forlogController(anything else throwsFST_ERR_LOG_INVALID_LOG_CONTROLLER), andLogControlleris exported fromfastifywith types.LogControlleronly gates per-request log lines (incoming, completed, request errors). It does not create or configure the logger, so the existinglogger: { level, stream }pipeline into the console reporter and the API websocket is unchanged.logRequestskeeps the same semantics (default suppressed,logRequests: true/--log-requestsemitted).forceCloseConnections: trueis untouched.Test plan
Fastify({ disableRequestLogging: false })prints FSTDEP023;Fastify({ logController: new LogController({ disableRequestLogging: false }) })does not.diststarted directly,GET /statussent, captureddelegate.logger.onMessageandwss.apiServer.send:Server listening;logRequests: true→Server listening,incoming request,request completed, on both channels, identical to mainpackages/authwith this build (--port 9011): no FSTDEP023;GET /statuslogged only with--log-requestsNo dev-server test suite exists, so verification was manual.