Repository navigation
Conversation
🦋 Changeset detectedLatest commit: daf0ff1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #256
With
"changelog": falsein.changeset/config.json,changeset versionbumps the versions but doesn't write anyCHANGELOG.mdfiles.runVersionthen readsCHANGELOG.mdfor every changed package to build the PR body, so it fails withENOENTand no version PR gets opened.runVersionnow handles a missingCHANGELOG.mdthe same waycreateReleasealready does: it assumes changelogs are disabled and lists the package in the PR body with just its## name@versionheading. Any other read error is still thrown.I added a test that runs
runVersionon the simple project fixture withchangelog: false. Before the change it failed with the sameENOENTerror from the issue.pnpm test,pnpm typecheckandpnpm formatall pass, and there's a patch changeset.If you'd rather leave these packages out of the PR body or handle it another way, I'm happy to change it.