[clue]

This changeset improves PHP 8.4+ support by avoiding implicitly nullable types as discussed in reactphp/promise#260. The same idea applies, but v1 requires manual type checks to support legacy PHP versions as the nullable type syntax requires PHP 7.1+ otherwise.

Builds on top of #22, #21, reactphp/promise#260 and reactphp/datagram#59

[sharkydog]

Contructor is missing the nullable type:

public function __construct(LoopInterface $loop = null)

should be:

public function __construct(?LoopInterface $loop = null)

[clue]

@sharkydog This PR is the fix for exactly that. The signature you're quoting is pre-merge. ?LoopInterface would need PHP 7.1+, 1.x still supports 5.3+, hence the manual instanceof check.

[sharkydog]

@clue I see now, I was looking at v1.2.0 tag.
So this change is not in packagist.

[sharkydog]

Any reason not to tag it as v1.2.1 for example?

[clue]

@sharkydog Release is on the list, but may take a little while. I'm balancing this with a number of other open-source priorities and everything else going on, and there are follow-up PHP version updates that will likely need coordinating before the next push. Will get to it when time allows.

If this project matters to you, please consider sponsoring. Every bit of support helps keep these projects alive, and knowing users actually care makes a real difference ❤️

[clue]

Just released https://github.com/clue/reactphp-multicast/releases/tag/v1.3.0 🎉

@sharkydog Thanks for your patience, a composer update should now pick this up 👍

This release also includes a round of updates to get this project back into good shape, #26 through #30, with more ideas like IPv6 support still open in #2. More sponsors directly translate to more updates like this, so if you'd like to see more, consider becoming a sponsor ❤️