Repository navigation
Update test environment to fix running tests on GitHub Actions - #65
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No blocking issues were identified in the scoped test-environment changes, although CI execution was not verified.
No open issues 🎉
What changed in this PR
This PR updates the test environment to restore GitHub Actions CI, using temporary workarounds for the unavailable SOAP service and dependency conflicts. The underlying react/http compatibility fix remains deferred to a follow-up PR.
Changes:
- Moves CI to Ubuntu 24.04 and updates the checkout action.
- Temporarily skips PHP 7.2 and internet-dependent tests.
- Adds
ringcentral/psr7as a development-only dependency.
| File | Description |
|---|---|
composer.json |
Adds the temporary PSR-7 dependency for the test suite. |
.github/workflows/ci.yml |
Updates the runner and checkout action, and applies temporary test exclusions. |
Review effort: Balanced
This was referenced Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset updates the test environment to fix running tests on GitHub Actions. CI could not run at all since the
ubuntu-20.04runner images were retired in April 2025, so this updates toubuntu-24.04and temporarily skips the functional tests relying on the unavailable SOAP service from #58 as well as legacy PHP 7.2 due to version conflicts.Note this also temporarily requires the dated ringcentral/psr7 package for the test suite only, so the tests pass again while the library itself is still broken with react/http v1.10+ for now. I've already prepared a follow-up PR that fixes this and drops this requirement again.
Builds on top of #55, #27, clue/reactphp-ssh-proxy#42 and others
Refs #58 and reactphp/http#522