Repository navigation
Conversation
…p timing, role waits Found while running the testomat.io e2e suite on Obscura. CDPBrowser (Obscura, Lightpanda, Chrome over CDP): - visibility: an inline or display:contents element with no box of its own (e.g. <a> wrapping a block card) is visible when a child is. Obscura reports no client rects for such inline elements. - synthetic click fires pointerdown/mousedown/focus/pointerup/mouseup before click, so widgets that react to mousedown/mouseup (ember power-select, Radix) work. - synthetic click on a non-interactive wrapper lands on the control at its center (elementFromPoint), like a coordinate click would. - traffic is recorded once the response finished loading (matching Playwright's requestfinished), and redirect hops are recorded. Playwright: waitFor* with role locators used [role="..."] css, ignoring native roles and the accessible name; build an internal:role selector. Core: HelperStep end time is taken when the async helper call settles, so step durations are no longer ~0ms. aiTrace: when a Before hook fails, only the running test writes the trace, instead of every test in the suite overwriting it. globalTimeout: ignore hook.finished for a suite hook that never fired hook.started (TypeError on __prevSuiteTimeout.slice). Co-Authored-By: Claude Opus 5.5 <[email protected]>
…ages Co-Authored-By: Claude Opus 5.5 <[email protected]>
cheerio is only used by test/unit/html_test.js; lib/ parses HTML with parse5. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cheerio is listed as a runtime dependency but nothing in
lib/orbin/imports it. The only consumer istest/unit/html_test.js; runtime HTML handling usesparse5and@xmldom/xmldom.Moving it to
devDependenciesdrops cheerio and its transitive tree (htmlparser2, domhandler, css-select, undici, …) from user installs.test/unit/html_test.jspasses locally (20 passing, 1 pending)🤖 Generated with Claude Code