Repository navigation
Conversation
michalsn
approved these changes
Oct 22, 2026
Member
|
Instead of a hand-rolled parser, we can use PHP's own |
post_max_size is unlimited
This comment has been minimized.
This comment has been minimized.
PHP treats post_max_size values of 0 or -1 as unlimited, but IncomingRequest compared Content-Length against the raw value, so the request body was never read. Use ini_parse_quantity() and treat non-positive values as PHP_INT_MAX.
gr8man
force-pushed
the
fix/incomingrequest-post-max-size-unlimited
branch
from
October 23, 2026 19:02
130e931 to
cfc5c72
Compare
paulbalandan
approved these changes
Oct 24, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PHP treats
post_max_sizevalues of0or-1as unlimited, butIncomingRequestcomparedContent-Lengthagainst the raw value, so the request body was never read. Non-positive values are now treated asPHP_INT_MAX.Checklist: