Repository navigation

fix: send a close frame for over-long reasons and invalid codes - #583

Open

mafredri wants to merge 20 commits into

masterfrom

mafredri/close-reason-truncate

Open

fix: send a close frame for over-long reasons and invalid codes#583
mafredri wants to merge 20 commits into
masterfrom
mafredri/close-reason-truncate

Commits on Oct 26, 2026
- fix(close): send fallback close frame for invalid codes
  mafredri
  committed
  6dd7707
- feat(close): truncate close reasons over 123 bytes
  mafredri
  committed
  8c4402d
- fix(wasm): truncate close reasons over 123 bytes
  mafredri
  committed
  b9bd0b1
- docs(close): limit the Close guarantee to the first call
  mafredri
  committed
  210a167
- fix: stop the truncation error from claiming bytes were sent
  mafredri
  committed
  bbff1f4
- docs(ws_js.go): note that invalid UTF-8 reasons can still be rejected
  mafredri
  committed
  5acf068
- test: cover U+FFFD at the limit and truncation with a write failure
  mafredri
  committed
  a0ecd2c
- fix: replace invalid UTF-8 in close reasons with U+FFFD
  mafredri
  committed
  2c06477
- docs(ws_js.go): document U+FFFD replacement in the Close reason
  mafredri
  committed
  8aca92c
- fix: report the replaced reason length in the truncation error
  mafredri
  committed
  3f004c2
- fix: put the close failure before the truncation error
  mafredri
  committed
  fb47d0a
- refactor: move wireCloseReason out of errors.go
  mafredri
  committed
  a72b2e3
- refactor: derive maxCloseReason from maxControlPayload again
  mafredri
  committed
  bc0ad88
- docs: drop comments that repeat the Close docs
  mafredri
  committed
  4b824e1
- docs: restore the comments that explain the close error handling
  mafredri
  committed
  e8ee102
- fix: say why a truncated reason is longer than the caller's
  mafredri
  committed
  75456f3
- fix: return the truncation error only when Close succeeds
  mafredri
  committed
  fc60274
- fix: encode every wireCloseError result in CloseError.bytes
  mafredri
  committed
  2d8a8ee
- docs(close): drop the Close doc line about non-nil errors
  mafredri
  committed
  04eeb2b
- fix: stop the invalid code error from claiming a frame was sent
  mafredri
  committed
  5fdd32d

Commits

Commits on Oct 26, 2026