Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since spec 0.30, a declaration is "the string
<!, an ASCII letter, zero or more characters not including the character>, and the character>". The HTML block start condition 4 is "<!followed by an ASCII letter". commonmark-java still follows the older rules in two places:HtmlBlockParserstarts a type 4 block only for an uppercase letter (^<![A-Z]), so a lowercase doctype is wrapped in a paragraph:commonmark-java:
<p><!doctype html></p>. cmark and commonmark.js:<!doctype html>.HtmlInlineParser.tryDeclarationstill requires whitespace after the letters, soinline <!FOO>andinline <!foo>are escaped (<!FOO>). cmark and commonmark.js render them as inline HTML.4ca7a59 ("Allow lowercase ASCII in HTML declaration (spec 0.30)") already updated the comment in
tryDeclarationto the new wording and switched the inline check to any ASCII letter. It kept the whitespace check, though, and did not touch the block pattern.Changes:
^<![A-Z]becomes^<![A-Za-z]inHtmlBlockParser.tryDeclarationis removed. ThenoDeclarationEndshortcut still prevents rescanning when there is no>; inputs like"<!A " * 30000and"<!A" * 30000render in well under a second.Tests:
SpecialInputTest.htmlBlockDeclarationWithLowercaseLetter.HtmlInlineParserTest.declarationno longer says "Whitespace is mandatory":<!FOO>is now expected to be inline HTML, plus a lowercase case without whitespace.afterFailedAttemptused<!foo>as the failing attempt; it now uses<!1>, which is still not HTML.The changed tests fail before the change and pass after.
mvn testpasses, except thatPathologicalTest.paragraphOfLinesThatTryBlockStartshit its 3 s timeout once on a heavily loaded machine. That test is unrelated and passes when run on its own, on main as well as on this branch.spotless:checkis clean.Found by differential testing against cmark.