Skip to content

Don't let lists interrupt a paragraph with only link reference definitions #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ybai08 wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −1
Open

Don't let lists interrupt a paragraph with only link reference definitions #472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion commonmark/src/main/java/org/commonmark/internal/ListBlockParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,8 @@ public BlockStart tryStart(ParserState state, MatchedBlockParser matchedBlockPar
}
int markerIndex = state.getNextNonSpaceIndex();
int markerColumn = state.getColumn() + state.getIndent();
boolean inParagraph = !matchedBlockParser.getParagraphLines().isEmpty();
// A paragraph that only has link reference definitions so far is still open
boolean inParagraph = matched.getBlock() instanceof Paragraph;
ListData listData =
parseList(state.getLine().getContent(), markerIndex, markerColumn, inParagraph);
if (listData == null) {
Expand Down
14 changes: 14 additions & 0 deletions commonmark/src/test/java/org/commonmark/test/SpecialInputTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,20 @@ public void linkReferenceDefinitionWithUnbalancedParens() {
"[foo]: a(b) \"t\"\n\n[foo]", "<p><a href=\"a(b)\" title=\"t\">foo</a></p>\n");
}

@Test
public void listCanNotInterruptParagraphWithOnlyLinkReferenceDefinitions() {
// The paragraph is still open, so the same rules apply as for a paragraph with text: an
// ordered list must start with 1 and an empty list item can not interrupt it
assertRendering(
"[foo]: /url\n2. a\n\n[foo]", "<p>2. a</p>\n<p><a href=\"/url\">foo</a></p>\n");
assertRendering("[foo]: /url\n-\n\n[foo]", "<p>-</p>\n<p><a href=\"/url\">foo</a></p>\n");
assertRendering("[foo]: /url \"t\"\n2. a", "<p>2. a</p>\n");
assertRendering("> [foo]: /url\n> 2. a", "<blockquote>\n<p>2. a</p>\n</blockquote>\n");
// These can interrupt it
assertRendering("[foo]: /url\n1. a", "<ol>\n<li>a</li>\n</ol>\n");
assertRendering("[foo]: /url\n- a", "<ul>\n<li>a</li>\n</ul>\n");
}

@Test
public void linkLabelLength() {
String label1 = "a".repeat(999);
Expand Down
Loading