Repository navigation
Conversation
Auto-generated by schema-propagation workflow. Source: constructive-db@9e51e92d33a
|
Review complete. 🟠 1 high 💬 Inline comments (1)
This PR threads a new optional
The SDK-side changes are internally consistent across packages, but the checked-in server-schema snapshots still lack the field, which is the one blocking issue below. Reviewed commit: 1103e92 |
There was a problem hiding this comment.
Adds an optional signOutOtherSessions flag to the SetPasswordInput SDK contract, but the flag is not yet implemented in the server schema, so generated clients sending it will fail validation.
Key findings
- 🟠 SDK advertises
signOutOtherSessionsabsent from server schema — auth.graphql:5506
| clientMutationId: String | ||
| currentPassword: String | ||
| newPassword: String | ||
| signOutOtherSessions: Boolean |
There was a problem hiding this comment.
🟠 bug · high
SDK advertises signOutOtherSessions absent from server schema
The PR adds signOutOtherSessions: Boolean to SetPasswordInput in the SDK SDL and all generated type copies (sdk/constructive-sdk/schemas/auth.graphql:5506, plus the schema-types.ts and three orm/input-types.ts copies), but the checked-in server-schema snapshots still describe the mutation without it: graphql/test-app/schema.graphql:24130 lists only clientMutationId, currentPassword, and newPassword, and graphql/query/__fixtures__/api/introspection.json matches.
A client generated from the new SDK that sends signOutOtherSessions gets a GraphQL validation error ("Field ... is not defined by type SetPasswordInput") on a security-relevant flow, and the schema gives no way to express the intended omitted-vs-false semantics (keep other sessions vs. explicitly keep them) to the server.
📋 Prompt for AI Agents
The new signOutOtherSessions: Boolean field on SetPasswordInput (sdk/constructive-sdk/schemas/auth.graphql line 5506, plus sdk/constructive-react/src/auth/schema-types.ts line 1369 and the three sdk/*/src/auth/orm/input-types.ts copies at line 2221) is not reflected in the server-schema snapshots: graphql/test-app/schema.graphql lines 24130-24138 and graphql/query/fixtures/api/introspection.json still define SetPasswordInput with only clientMutationId/currentPassword/newPassword. Regenerate these snapshot artifacts from the server schema that includes signOutOtherSessions (or include the server-side change implementing the field in this same change set), so SDK clients sending signOutOtherSessions do not hit GraphQL validation errors. Document the intended semantics of omitted vs explicitly false for the nullable Boolean in the field description.
Automated Schema + SDK Update
This PR was created by the schema-propagation workflow.
What changed
Updated schema files from constructive-db and regenerated ALL SDK clients.
Source:
constructive-db@9e51e92d33aSchemas updated
sdk/constructive-sdk/schemas/— all API targets from constructive-db (auto-discovered)sdk/migrate-client/schemas/— migratepgpm/export/src/meta-export-tables.json— generated meta export table listClients regenerated
sdk/constructive-sdk/src/— ORM clientsdk/constructive-cli/src/— CLI clientsdk/constructive-react/src/— React hookssdk/migrate-client/src/— Migrate clientSkill references updated
.agents/skills/— Generated skill documentationAuto-generated by constructive-hub schema-propagation