Repository navigation
fix(Dropdown): return focus to the toggle when the menu closes from inside it - #329
Merged
Merged
Conversation
…nside it - item, cDropdownClose, click in the menu, close from code: focus goes back once the menu was used since it opened (focusin, pointerdown or keydown in it) and the window has focus - only when focus is in the menu, on the body or nowhere; focus moved elsewhere stays - after the render, as program focus, without scrolling; Escape still scrolls - after a touch or pen in the menu, text inputs, textareas and contenteditable targets are skipped - a repeated Enter on the toggle or a control inside it is ignored - internal DropdownFocusReturn token, given in viewProviders and injected with host, names the targets for the dropdown in a component's own template - restoreFocus: optional focus function, focus read in the root of the overlay and of the target
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since it opened (focusin, pointerdown or keydown in it) and the window has focus
targets for the dropdown in a component's own template