Repository navigation
fix(updater): n-port tickers only for common stock, state suffix in names, no float artifacts in cells - #91
Merged
Conversation
…ames, no float artifacts in cells
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
nport-readerblock (workspaceetf-std/nport-reader.block.ts5935f58, open items Q31 and Q34):nportTickersgives a ticker only to common stock (assetCat EC); a preferred (EP), a contingent value right (placeholder CUSIP like436CVR021or a- CVRtitle), a right, a warrant or an escrow line gets none, since a name match gave it the issuer's common ticker.nportNameKeyalso strips a trailing parenthesised state suffix (ACUITY INC. (DE)= AYI) andnportCellprints the shortest text of the rounded number (115797518.01, not115797518.01000001)Why
Preferreds, CVRs and rights were published under the issuer's common ticker (SPUS TPG CVR as TPG, a Novo Nordisk CVR as NVO), and an EP row sharing a ticker with the common row knocked the ticker off the common row too; large N-PORT balances showed binary float artifacts
Effect on real filings
Newest real N-PORT-P filing read with this repo's own
readNportHoldings+nportTickers(published rows 0, as with the fund folder removed),origin/mainupdater vs this branch on byte-identical cached SEC answers; the published Ticker column is compared; nothing written toapi/:Checks
bun testandbun testwith everyupdate-data.config.jsoncontrol exported: 66 pass 0 fail (with config env: 66 pass 0 fail), exit 0bun build --target=bun scripts/update-data.ts --outfile=/dev/null,bun build --target=bun src/main.tsx --outfile=/dev/null,git diff --checkapply-block.ts --check nport-reader .: identical;check-scripts.ts: ok;tc/check.sh .: no new errors (52 lines, before 52)blocks.test.ts: 14 pass