Skip to content

fix(updater): n-port tickers only for common stock, state suffix in names, no float artifacts in cells - #91

Merged
daggerok merged 1 commit into
mainfrom
fix/nport-common-stock-tickers
Oct 26, 2026
Merged

daggerok merged 1 commit into
mainfrom
fix/nport-common-stock-tickers

Conversation

@daggerok

Copy link
Copy Markdown
Owner

What changed

  • Re-applied the shared nport-reader block (workspace etf-std/nport-reader.block.ts 5935f58, open items Q31 and Q34): nportTickers gives a ticker only to common stock (assetCat EC); a preferred (EP), a contingent value right (placeholder CUSIP like 436CVR021 or a - CVR title), a right, a warrant or an escrow line gets none, since a name match gave it the issuer's common ticker. nportNameKey also strips a trailing parenthesised state suffix (ACUITY INC. (DE) = AYI) and nportCell prints the shortest text of the rounded number (115797518.01, not 115797518.01000001)

Why

Preferreds, CVRs and rights were published under the issuer's common ticker (SPUS TPG CVR as TPG, a Novo Nordisk CVR as NVO), and an EP row sharing a ticker with the common row knocked the ticker off the common row too; large N-PORT balances showed binary float artifacts

Effect on real filings

Newest real N-PORT-P filing read with this repo's own readNportHoldings + nportTickers (published rows 0, as with the fund folder removed), origin/main updater vs this branch on byte-identical cached SEC answers; the published Ticker column is compared; nothing written to api/:

DES (2026-06-30, 525 positions): tickers 519 -> 519, 0 changed
DGRS (2026-06-30, 201 positions): tickers 198 -> 198, 0 changed
DLN (2026-06-30, 312 positions): tickers 308 -> 308, 0 changed
TOTAL 0 ticker changes, 0 value cells

Checks

  • bun test and bun test with every update-data.config.json control exported: 66 pass 0 fail (with config env: 66 pass 0 fail), exit 0
  • bun build --target=bun scripts/update-data.ts --outfile=/dev/null, bun build --target=bun src/main.tsx --outfile=/dev/null, git diff --check
  • apply-block.ts --check nport-reader .: identical; check-scripts.ts: ok; tc/check.sh .: no new errors (52 lines, before 52)
  • Template tests blocks.test.ts: 14 pass

@daggerok
daggerok merged commit fbea963 into main Oct 26, 2026
1 check passed
@daggerok
daggerok deleted the fix/nport-common-stock-tickers branch October 26, 2026 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant